Add statistics handling to the Alluxio metastore support#14018
Merged
highker merged 1 commit intoprestodb:masterfrom Feb 2, 2020
Merged
Add statistics handling to the Alluxio metastore support#14018highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
highker
reviewed
Jan 28, 2020
There was a problem hiding this comment.
nit
Table table = getTable(databaseName, tableName).orElseThrow(() -> new TableNotFoundException(new SchemaTableName(databaseName, tableName)));There was a problem hiding this comment.
- spell out
colStatsMap - null assignment is useless
Contributor
|
@highker comments addressed. Thanks! |
highker
reviewed
Jan 28, 2020
There was a problem hiding this comment.
No need to have this. Use makePartName from MetastoreUtil instead of FileUtils.makePartName
There was a problem hiding this comment.
the formatting is not aligned
columnStats = client.getPartitionColumnStatistics(
table.getDatabaseName(),
table.getTableName(),
partitionBasicStatistics.keySet().stream().collect(toImmutableList()),
dataColumns);There was a problem hiding this comment.
Is alluxio metastore a thrift-based metastore? If not, shall we restructure the util classes so that this class does not depend on ThriftMetastoreUtil? MetastoreUtil might be the right place to host some helpers.
There was a problem hiding this comment.
Move private functions to the end of a class. Move public ones to the beginning.
yuzhu
force-pushed
the
stats
branch
3 times, most recently
from
22684d1 to
819acc4
Compare
highker
reviewed
Feb 1, 2020
There was a problem hiding this comment.
Same, it's better not to depend on thrift utils for non-thrift metastore.
Co-authored-by: David Zhu <david@alluxio.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: David Zhu david@alluxio.com
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.